ENH: Allow for infinite duration audio recording#7060
Merged
peircej merged 4 commits intopsychopy:devfrom Jan 22, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #7060 +/- ##
==========================================
- Coverage 50.03% 50.00% -0.03%
==========================================
Files 347 347
Lines 63989 64045 +56
==========================================
+ Hits 32015 32028 +13
- Misses 31974 32017 +43
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the requirement to pre-allocate a buffer for audio recording samples. The
maxRecordingSizeparameter when set to-1orNonewill allow the microphone to record continuously until stopped. Audio samples are stored as fragments and concatenated only when the recording is retrieved. A separate algorithm is used to access the last few samples across fragments very quickly for the real-timegetCurrentVolume()function.