Skip to content

BF: Remove "Close" buttons from Runner tabs#6997

Merged
TEParsons merged 1 commit intopsychopy:devfrom
TEParsons:dev-bf-runner-close-tab
Dec 11, 2024
Merged

BF: Remove "Close" buttons from Runner tabs#6997
TEParsons merged 1 commit intopsychopy:devfrom
TEParsons:dev-bf-runner-close-tab

Conversation

@TEParsons
Copy link
Copy Markdown
Contributor

Closing any of the tabs would lead to an error as soon as something needed to be written to it - they only had a close button because it's the default in wx.aui.AuiNotebook, there's not really any need for any of them to close.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.84%. Comparing base (979dd61) to head (0f2b8dc).
Report is 16 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #6997   +/-   ##
=======================================
  Coverage   50.84%   50.84%           
=======================================
  Files         340      340           
  Lines       62334    62336    +2     
=======================================
+ Hits        31691    31693    +2     
  Misses      30643    30643           
Components Coverage Δ
app ∅ <ø> (∅)
boilerplate ∅ <ø> (∅)
library ∅ <ø> (∅)
vm-safe library ∅ <ø> (∅)

@TEParsons TEParsons merged commit 9f1eea8 into psychopy:dev Dec 11, 2024
@TEParsons TEParsons deleted the dev-bf-runner-close-tab branch December 16, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant