Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #6967 +/- ##
==========================================
+ Coverage 41.66% 50.46% +8.79%
==========================================
Files 341 346 +5
Lines 62352 62748 +396
==========================================
+ Hits 25978 31664 +5686
+ Misses 36374 31084 -5290
|
Member
Author
|
Added attributes for joysticks/gamepads that support spatial and motion tracking (e.g. Oculus Touch controllers). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made some changes the the Joystick class:
getAllJoysticksto get a human-readable list of devicesid->deviceIndexto avoid overriding built-in, you can still passidbut we shouldn't allow that in a future version