ENH: Added case-sensitive search and search-as-you-type in Builder search#6947
Merged
TEParsons merged 1 commit intopsychopy:devfrom Oct 31, 2024
Merged
ENH: Added case-sensitive search and search-as-you-type in Builder search#6947TEParsons merged 1 commit intopsychopy:devfrom
TEParsons merged 1 commit intopsychopy:devfrom
Conversation
- Search as you type. - Case-sensitive is no longer the default, but is still possible by ticking a checkbox. - The name of the routine where a component is located is now also displayed in the search results.
Contributor
|
All looks good! Only worry I had was that on-typing search would feel laggy, particularly for big experiments, but actually testing this out on my mid-range laptop it's absolutely fine. I guess it's ultimately just doing basic string matching in an array so seems to return in a matter of milliseconds. So yep happy to pull in once tests pass, thanks for contributing! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #6947 +/- ##
==========================================
- Coverage 50.78% 50.77% -0.01%
==========================================
Files 334 334
Lines 61705 61716 +11
==========================================
Hits 31338 31338
- Misses 30367 30378 +11
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Search as you type.
Case-sensitive is no longer the default, but is still possible by ticking a checkbox.
The name of the routine where a component is located is now also displayed in the search results.