ENH: Allow non-WASAPI audio devices#6922
Merged
peircej merged 1 commit intopsychopy:devfrom Oct 25, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #6922 +/- ##
=======================================
Coverage 50.71% 50.71%
=======================================
Files 333 333
Lines 61685 61688 +3
=======================================
+ Hits 31285 31287 +2
- Misses 30400 30401 +1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to use ASIO drivers for a particular hardware soundcard, so I have compiled a custom pyaudio + psychtoolbox with ASIO support, but psychopy filters out non-WASAPI audio devices.
This adds a config option that on windows allows you to use ASIO (or WDM-KS if you would even want to).
The default for
prefs.hardware['audioWASAPIOnly']isTruefor windows,Falseotherwise.This isn't necessarily useful for anything outside of edge cases like ours, but I can imagine that more than one research group uses ASIO low-latency hardware with multi-channel output support.
On a separate note, if it's useful, I can make another PR with some modifications I made to
SoundPTBto allow for an arbitrary number of output channels (not just mono or stereo), we use 3-channel output (left, right and a Manchester Encoded trigger channel to a trigger box).