BF: Better error handling when getting recording from mic that's still recording#6908
Merged
peircej merged 1 commit intopsychopy:devfrom Oct 11, 2024
Merged
Conversation
…c rather than error
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #6908 +/- ##
==========================================
- Coverage 50.73% 50.72% -0.01%
==========================================
Files 333 333
Lines 61633 61634 +1
==========================================
- Hits 31268 31265 -3
- Misses 30365 30369 +4
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tagging @mdcutone for review to make sure the hard error here isn't needed - does
stopdo anything asynchronous which we need to be wary of when calling immediately before a save?