ENH: Include details about sample rate and channels in SpeakerDevice#6867
Merged
TEParsons merged 3 commits intopsychopy:devfrom Sep 20, 2024
Merged
ENH: Include details about sample rate and channels in SpeakerDevice#6867TEParsons merged 3 commits intopsychopy:devfrom
TEParsons merged 3 commits intopsychopy:devfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #6867 +/- ##
==========================================
- Coverage 49.58% 49.56% -0.02%
==========================================
Files 332 332
Lines 61370 61382 +12
==========================================
- Hits 30429 30425 -4
- Misses 30941 30957 +16
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As each speaker reports its sample rate and number of channels, it makes much more sense for this to be stored in SpeakerDevice than for Sound to work it out each time.
This also makes the bug where Sound initialised without specifying
stereobreaks irrelevant - as if you specify a Sound without stereo, it works it out from the speaker.