Skip to content

BF: Linux iohub keyboard relative import error#6858

Merged
peircej merged 1 commit intopsychopy:devfrom
zeyus-research:master
Oct 2, 2024
Merged

BF: Linux iohub keyboard relative import error#6858
peircej merged 1 commit intopsychopy:devfrom
zeyus-research:master

Conversation

@zeyus
Copy link
Copy Markdown
Contributor

@zeyus zeyus commented Sep 16, 2024

When running psychopy on linux, using the iohub mouse device results in an importerror:

ImportError: cannot import name 'Keyboard' from 'psychopy.iohub.devices'

This fixes the import error by aligning the linux mouse device variant to the other OS variants.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.57%. Comparing base (c1677ae) to head (2110f49).
Report is 43 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6858      +/-   ##
==========================================
- Coverage   49.58%   49.57%   -0.01%     
==========================================
  Files         332      332              
  Lines       61370    61371       +1     
==========================================
- Hits        30429    30427       -2     
- Misses      30941    30944       +3     
Components Coverage Δ
app ∅ <ø> (∅)
boilerplate ∅ <ø> (∅)
library ∅ <ø> (∅)
vm-safe library ∅ <ø> (∅)

@TEParsons
Copy link
Copy Markdown
Contributor

Thanks for catching this! The fix looks good to me, @mdcutone can you confirm?

@peircej peircej merged commit 902c109 into psychopy:dev Oct 2, 2024
@peircej
Copy link
Copy Markdown
Member

peircej commented Oct 2, 2024

Is this not a problem in release branch too (or is it actually a FF not a BF)?

@zeyus
Copy link
Copy Markdown
Contributor Author

zeyus commented Oct 2, 2024

Is this not a problem in release branch too (or is it actually a FF not a BF)?

Yeah I noticed it first in release, should I have made the PR against main?

@peircej
Copy link
Copy Markdown
Member

peircej commented Oct 2, 2024

Yes, for a bug fix, should really check out release branch and PR back to release branch but no worries. We make bug-fix releases from that branch and dev branch is kept for major versions (ie. a bug fix to dev will only get released in Feb or June)

I'll cherry-pick to release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants