BF: Fix bug where "ERROR" logs showed up as "DEPRECATION"#6836
Merged
TEParsons merged 1 commit intopsychopy:devfrom Sep 6, 2024
Merged
BF: Fix bug where "ERROR" logs showed up as "DEPRECATION"#6836TEParsons merged 1 commit intopsychopy:devfrom
TEParsons merged 1 commit intopsychopy:devfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6836 +/- ##
=======================================
Coverage 49.57% 49.57%
=======================================
Files 332 332
Lines 61281 61281
=======================================
+ Hits 30380 30382 +2
+ Misses 30901 30899 -2
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
logging.error(and similar functions) didn't explicitly state a label, the label used was just the first one found which matched the numeric log level. Because both ERROR and DEPRECATION have the same numeric log level, error logs were getting the label DEPRECATION instead. Explicitly stating the label to match the function called fixes this.