ENH: added the option for an expVersion into the SettingsComponent#6830
Merged
peircej merged 2 commits intopsychopy:devfrom Sep 5, 2024
Merged
ENH: added the option for an expVersion into the SettingsComponent#6830peircej merged 2 commits intopsychopy:devfrom
peircej merged 2 commits intopsychopy:devfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6830 +/- ##
==========================================
- Coverage 49.58% 49.58% -0.01%
==========================================
Files 332 332
Lines 61269 61275 +6
==========================================
+ Hits 30381 30383 +2
- Misses 30888 30892 +4
|
Because this is a string parameter we shouldn't encapsulate in quotes (that's handled automatically by the parameter class)
Member
Author
|
This seems to be working fine. By including in expInfo it makes it into the data file and it seems pretty straightforward and useful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In general this is useful to keep track of the experiment version but this is a first draft and we should check if it works (e.g. does it show up in the csv file). Very much untested as yet