BF: Distinguish between a trial that's been skipped and a trial that's currently skipping#6807
Merged
TEParsons merged 2 commits intopsychopy:devfrom Aug 23, 2024
Merged
Conversation
…s currently skipping
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6807 +/- ##
==========================================
- Coverage 49.05% 49.03% -0.02%
==========================================
Files 332 332
Lines 61220 61226 +6
==========================================
- Hits 30031 30025 -6
- Misses 31189 31201 +12
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise TrialHandler2.rewindTrials will skip the trial you were on when you rewound once it gets back to it, because it's now marked as skipped. We need to distinguished between "this has been skipped before" and "this needs to end its Routines"