Skip to content

BF: pin pip to 24.0 for plugins on py3.8#6758

Merged
peircej merged 1 commit intopsychopy:releasefrom
peircej:release
Aug 1, 2024
Merged

BF: pin pip to 24.0 for plugins on py3.8#6758
peircej merged 1 commit intopsychopy:releasefrom
peircej:release

Conversation

@peircej
Copy link
Copy Markdown
Member

@peircej peircej commented Jul 31, 2024

fixes #6734

pip 24.1.2 works fine on py3.10 but crashes plugin install on py3.8 on macos

thanks to @mh105 for tracking down

fixes psychopy#6734

pip 24.1.2 works fine on py3.10 but crashes plugin install on py3.8 on macos

thanks to @mh105 for tracking down
@peircej
Copy link
Copy Markdown
Member Author

peircej commented Jul 31, 2024

I'm having some doubts here - we could just apply this to the build of standalone (handled by a private devops repo) rather than to the pyproject.toml. The downside of pinning here is that it will alter a lot of people's python installations, and cause pip annoying warnings and potentially poetry/pdm resolver clashes for downstream packages

@mh105
Copy link
Copy Markdown
Contributor

mh105 commented Jul 31, 2024

Making it an exclusive change to py3.8 standalone app sounds good to me...

One possible issue is that folks doing pip install psychopy with pip > 24.0 might have trouble using the Plugins & Packages Manager to install plugin packages if they open the builder from this installation.

But I don't know how many people actually pip install themselves AND also use the builder - everyone I interact with use either standalone + builder or pip install + coder, and they can probably figure out pip installing plugin packages themselves as well if they pip installed psychopy in the first place :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants