Skip to content

ENH: Make install behaviour consistent between plugins and packages#6646

Closed
TEParsons wants to merge 7 commits intopsychopy:devfrom
TEParsons:dev-enh-plugin-dlg
Closed

ENH: Make install behaviour consistent between plugins and packages#6646
TEParsons wants to merge 7 commits intopsychopy:devfrom
TEParsons:dev-enh-plugin-dlg

Conversation

@TEParsons
Copy link
Copy Markdown
Contributor

@TEParsons TEParsons commented Jul 1, 2024

Some of the recent improvements to pkgtools weren't accessible from Builder as Builder uses a different function to install plugins when the install button is clicked. This PR adds the necessary parameters to pkgtools.installPackage so that Builder can use that function instead (without losing the ability to do an asynchronous install)

@TEParsons TEParsons requested a review from mdcutone July 1, 2024 10:32
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 14.28571% with 30 lines in your changes missing coverage. Please review.

Project coverage is 50.08%. Comparing base (b3a3988) to head (6e0d503).
Report is 36 commits behind head on dev.

❗ Current head 6e0d503 differs from pull request most recent head ea479ea

Please upload reports for the commit ea479ea to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #6646      +/-   ##
==========================================
- Coverage   50.82%   50.08%   -0.74%     
==========================================
  Files         332      332              
  Lines       61057    61113      +56     
==========================================
- Hits        31030    30607     -423     
- Misses      30027    30506     +479
Components Coverage Δ
app ∅ <ø> (∅)
boilerplate ∅ <ø> (∅)
library ∅ <ø> (∅)
vm-safe library ∅ <ø> (∅)

@peircej
Copy link
Copy Markdown
Member

peircej commented Jul 1, 2024

Are these actually bug fixes or ENHancements? It's a lot of code. Is it necessary?

@TEParsons
Copy link
Copy Markdown
Contributor Author

TEParsons commented Jul 1, 2024

I guess we could figure out exactly what the difference is and modify EnvironmentManagerDlg.installPackage to match pkgtools.installPackage instead, which would be fewer lines changed, but the latter is definitely the correct behaviour so it made more sense to just use it rather than trying to recreate it.

There's also some smaller UI improvement stuff here which I'll cherry pick to a different PR so we can focus on the main change here.

@TEParsons TEParsons changed the title ENH: Improvements to plugin/packages dialog ENH: Make install behaviour consistent between plugins and packages Jul 1, 2024
@TEParsons TEParsons mentioned this pull request Jul 24, 2024
Merged
@TEParsons TEParsons closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdcutone mdcutone Awaiting requested review from mdcutone

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TEParsons @peircej