Skip to content

refactor: use WaitGroup#Go to replace wg.Add(1)/go/wg.Done() boilerplate #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
psviderski merged 1 commit into from
Dec 19, 2025
Merged

refactor: use WaitGroup#Go to replace wg.Add(1)/go/wg.Done() boilerplate #222

psviderski merged 1 commit into from
Dec 19, 2025

Conversation

@jabr
Copy link
Contributor

@jabr jabr commented Dec 17, 2025

Small refactor cleanup suggested by Go modernizer: https://pkg.go.dev/golang.org/x/tools/go/analysis/passes/modernize#hdr-Analyzer_waitgroup

It replaces the common pattern

wg.Add(1)
go func() {
	defer wg.Done()
	...
}()

with a single call to

wg.Go(func(){ ... })

@jabr jabr changed the title refactor: use WaitGroup.Go to replace wg.Add(1)/go/wg.Done() boilerplate refactor: use WaitGroup#Go to replace wg.Add(1)/go/wg.Done() boilerplate Dec 17, 2025
psviderski
psviderski approved these changes Dec 19, 2025
View reviewed changes
Copy link
Owner

@psviderski psviderski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@psviderski psviderski merged commit 65e9cdd into psviderski:main Dec 19, 2025
4 checks passed
@jabr jabr deleted the modernize-waitgroup branch December 20, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@psviderski psviderski psviderski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jabr @psviderski