refactor: Simplify dns e2e test using new ExecContainer functionality #178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DNS e2e tests required a convoluted process of launching a new query service for each test that wrote nslookup output to a file in host-mounted volume that we then read from the ucind container.
With the new ExecContainer functionality, that can be simplified to an effective
uc exec dns-query-service nslookup {...}where we can read the output directly.