feat: Adding a "nearest.service.local" mode to internal DNS #159
Conversation
There was a problem hiding this comment.
Great addition to the list of supported internal DNS records! 👏
Everything looks good, just one note on not coupling the server implementation with the details of uncloud networking.
I did some research and not sure if need to change the default to nearest: #154 (comment)
Perhaps leaving the current random behaviour is fine.
Please let me know once you test this. Also would be nice to add the info about the new record to the doc page you wrote earlier 🙏
Awesome work as always! ❤️
|
Just trying out an idea, but I also added a "rr" mode with an explicit round-robin (rather than random) based on a count of total lookups the server has resolved so far (so not really round-robin, I guess, as it's not specific to that exact name...). The default behavior is still just random shuffle. I'll follow up in #154. |
|
I'm not sure if the approach based on |
…ork.MachineIP)
Also adds an exact round-robin via "rr.{service}" mode. Not sure we want that over random or not, though.
… now the same as default with random shuffle.
62d0c87 to
db81ff3
Compare
I think it's good to go now, but let me know if you have any notes. |
Related issue: #154
Added "nearest" internal DNS mode the puts machine-local IPs at the start of responses. Also added a "rr" mode that has the same, random shuffle behavior of the current default.
I've tested this build on my cluster.