-
-
Notifications
You must be signed in to change notification settings - Fork 116
feat: Initial support for Compose configs #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@psviderski ready for an initial review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Really love how configs are copied to a created container before starting it.
I left a bunch of minor comments mainly focused on the consistency of the API. It's mainly used internally at this stage (Compose is the main user interface for now). But it would still be hard to make breaking changes in it later.
Btw, did you have any plans to add configs support to uc run command? For example, using a format similar to volumes: --config ./local/path:/container/path. Not critical at all, could be done in a separate PR later though.
Not in the initial implementation for sure; I don't mind supporting it, but TBH wouldn't use this myself. |
psviderski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work! 👏
Resolves #43.
This adds initial support for Compose configs.
Configs are basically arbitrary data objects that are copied to files inside the uncloud-managed containers on startup.
Supported:
filesource: using content from a file on the local (control node) filesystem.contentsource: using inline content from the Compose fileNot supported:
environmentsource -- should be straightforward to add in a follow-up.TODOs for this PR: