Skip to content

Conversation

@tonyo
Copy link
Collaborator

@tonyo tonyo commented Sep 4, 2025

Resolves #43.

This adds initial support for Compose configs.
Configs are basically arbitrary data objects that are copied to files inside the uncloud-managed containers on startup.

Supported:

  • file source: using content from a file on the local (control node) filesystem.
  • content source: using inline content from the Compose file

Not supported:

  • External configs -- and probably won't be, unless we pivot towards configs being first-class citizens as in Swarm.
  • environment source -- should be straightforward to add in a follow-up.

TODOs for this PR:

  • Adding basic docs.

@tonyo tonyo requested a review from psviderski September 4, 2025 23:14
@tonyo
Copy link
Collaborator Author

tonyo commented Sep 4, 2025

@psviderski ready for an initial review

Copy link
Owner

@psviderski psviderski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Really love how configs are copied to a created container before starting it.
I left a bunch of minor comments mainly focused on the consistency of the API. It's mainly used internally at this stage (Compose is the main user interface for now). But it would still be hard to make breaking changes in it later.

Btw, did you have any plans to add configs support to uc run command? For example, using a format similar to volumes: --config ./local/path:/container/path. Not critical at all, could be done in a separate PR later though.

@tonyo
Copy link
Collaborator Author

tonyo commented Sep 24, 2025

Btw, did you have any plans to add configs support to uc run command? For example, using a format similar to volumes: --config ./local/path:/container/path.

Not in the initial implementation for sure; I don't mind supporting it, but TBH wouldn't use this myself.

Copy link
Owner

@psviderski psviderski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! 👏

@psviderski psviderski merged commit 63c4de5 into main Sep 26, 2025
4 checks passed
@psviderski psviderski deleted the tonyo/explore-configs-1 branch September 26, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Compose configs

3 participants