refactor: Update chnnlsv function names and structure definition#337
Merged
sharkwouter merged 1 commit intopspdev:masterfrom Jan 2, 2026
Merged
refactor: Update chnnlsv function names and structure definition#337sharkwouter merged 1 commit intopspdev:masterfrom
sharkwouter merged 1 commit intopspdev:masterfrom
Conversation
sharkwouter
reviewed
Jan 1, 2026
Member
sharkwouter
left a comment
There was a problem hiding this comment.
Thanks @GrayJack, this looks like a big improvement! I did have 2 questions about things that are probably not wrong, but look a bit off when compared to the old code, you find them below. It would be nice to have some example code for how to use this, but since this doesn't seem like something people use, I would also merge it as is if the 2 things I found are not errors.
sharkwouter
approved these changes
Jan 2, 2026
Member
sharkwouter
left a comment
There was a problem hiding this comment.
Thanks for the clarification! I'll merge this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based in PSPlibdoc and uofw.
Included macros and typedefs to maintain some sort of backwards compatibility.