refactor: Update SceModule definition#328
Conversation
|
Hey @GrayJack thanks for the PR. It seems there are still some conflicts in the code. I was not able to build it. |
|
Oops, there was a silly type error, I updated it |
Avoids type definition conflicts.
|
Just to let you know, I have not forgotten about this, but I don't know if I'll be able to test this this week. Next week I'll be able to test and merge this, though. |
sharkwouter
left a comment
There was a problem hiding this comment.
This looks fine to me, I'll ask in Discord one more time. I was able to build this and build and run OceanPop with this change.
If it's of any help (when it comes to taking a decision): I've personally reviewed this myself and I'm sure it's correct. The SceModule structure is essential for CFW development (and kernel-code in general), and it had inconsistencies, some of which were dangerous (a missing field made other fields not align with reality). The SDK has never updated this structure, forcing CFW (and other kernel-level devs) to use an alternative SceModule2. With this fix we can finally have a unified structure given to us by the kernel itself. |
|
That helps! Thanks for the input @JoseAaronLopezGarcia :) |
Update the
SceModuledefinition according to RE done on uofw.According to some talk on discord, this type definition never changed between firmware versions. So this PR also fixes a bug where there should be 160 bits between
stub_sizeandentry_addrfields, but there was128bits between those two fields.