Merged
Conversation
sharkwouter
requested changes
Feb 10, 2026
Member
sharkwouter
left a comment
There was a problem hiding this comment.
This looks pretty good, thanks for the effort! I've suggested a small change that fixes the pkgconf file. Otherwise I think this is okay.
Contributor
Author
|
If i get it, change was meant to fix broken substitution from CMake install step? |
Member
|
The fix is enough. We use something similar in most packages in this repo. |
Member
|
This looks good now, thanks! |
Contributor
Author
|
thank you for your help ^^ i also have a port of litehtml working imma try to polish before making another pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds fine on my machine ^^'
Lmk if i missed something