Merged
Conversation
added 2 commits
January 29, 2026 22:39
sharkwouter
requested changes
Feb 1, 2026
Member
sharkwouter
left a comment
There was a problem hiding this comment.
Hey @sl4shed, thanks for this PR and sorry for not getting to this earlier. I had 2 small comments, but otherwise this looks good.
sharkwouter
approved these changes
Feb 1, 2026
Member
|
Looks good now. I will let the build run and take another look inside the packages. Then I'll merge if everything looks good there |
Member
|
Could you still patch the pkgconf files to look at ${PSPDEV}? You can search for .pc in this repo and copy that approach. |
Member
|
Here is an example: Line 17 in 090b47b |
Member
|
Thanks! I added an additional commit to do a final small fix to the .pc files and merged this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For spdlog I patch out some functions that are not available on the psp (some filesystem related stuff) and replace them.
For fmt originally I had no issues however I encountered some linker errors regarding flockfile and funlockfile so I patch those out too