Skip to content

opus: Build libopus and opusfile for PSP#268

Merged
sharkwouter merged 5 commits intopspdev:masterfrom
joel16:opus
Jan 13, 2026
Merged

opus: Build libopus and opusfile for PSP#268
sharkwouter merged 5 commits intopspdev:masterfrom
joel16:opus

Conversation

@joel16
Copy link
Contributor

@joel16 joel16 commented Jan 11, 2026

No description provided.

sharkwouter
sharkwouter requested changes Jan 11, 2026
View reviewed changes
Copy link
Member

@sharkwouter sharkwouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @joel16, thanks a lot for the PR! This would be good to have :)

The PR looks pretty good, but I'm still seeing some issues with the pkg-config files. The opusfile.pc file from the opusfile package is completely fine, but opusurl.pc from the same package still has the prefix set wrong. The opus package has an opus.pc file that needs work too, there all the paths are still hardcoded.

@sharkwouter
Copy link
Member

sharkwouter commented Jan 11, 2026

Let me know if you need any help :)

@joel16
Copy link
Contributor Author

joel16 commented Jan 11, 2026 •
edited
Loading

@sharkwouter no problem. I was under the impression opusurl was not going to be used so I didn't mess with that and was intentionally left out. This is also why I configured it with --disable-http. Please let me know what needs to be done to get it fixed.

@sharkwouter
Copy link
Member

sharkwouter commented Jan 11, 2026

I made a small change to fix the pc file for opus, but for some reason it seems opusfile is no longer building now. I'm investigating it. Sorry for the annoyance.

@sharkwouter
Copy link
Member

sharkwouter commented Jan 11, 2026

I don't think this is my code, could you also look into it? I'm a bit confused.

@joel16
Copy link
Contributor Author

joel16 commented Jan 11, 2026

I don't think this is my code, could you also look into it? I'm a bit confused.

I'll have a look, it was running fine locally so not sure what's wrong.

@sharkwouter
Copy link
Member

sharkwouter commented Jan 12, 2026

I think the problem is not that the header can't be found, but that it cannot be included. I'm not exactly sure what is up, though. I can reproduce this locally.

@joel16
Copy link
Contributor Author

joel16 commented Jan 12, 2026

@sharkwouter what command are you using locally? I assumed its because it couldn't find the opus headers and therefore added the clags to point to that path. I did test all of this locally by cd'ing into the opusfile directory and using psp-makepkg -i and it appears to be working:

------------------------------------------------------------------------
  opusfile 0.12: Automatic configuration OK.

    Assertions ................... no

    HTTP support ................. no
    Fixed-point .................. yes
    Floating-point API ........... yes

    Hidden visibility ............ yes

    API code examples ............ no
    API documentation ............ no
------------------------------------------------------------------------

  CC       src/info.lo
  CC       src/internal.lo
  CC       src/opusfile.lo
  CC       src/stream.lo
  CC       src/libopusurl_la-http.lo
  CC       src/libopusurl_la-internal.lo
  CCLD     libopusfile.la
  CCLD     libopusurl.la
==> Entering fakeroot environment...
==> Starting package()...
 /usr/bin/mkdir -p '/home/joel16/psp/psp-packages/opusfile/pkg/opusfile/psp/share/doc/opusfile'
 /usr/bin/mkdir -p '/home/joel16/psp/psp-packages/opusfile/pkg/opusfile/psp/include/opus'
 /usr/bin/mkdir -p '/home/joel16/psp/psp-packages/opusfile/pkg/opusfile/psp/lib/pkgconfig'
 /usr/bin/mkdir -p '/home/joel16/psp/psp-packages/opusfile/pkg/opusfile/psp/lib'
 /bin/bash ./libtool   --mode=install /usr/bin/install -c   libopusfile.la libopusurl.la '/home/joel16/psp/psp-packages/opusfile/pkg/opusfile/psp/lib'
 /usr/bin/install -c -m 644 opusfile.pc opusurl.pc '/home/joel16/psp/psp-packages/opusfile/pkg/opusfile/psp/lib/pkgconfig'
 /usr/bin/install -c -m 644 include/opusfile.h '/home/joel16/psp/psp-packages/opusfile/pkg/opusfile/psp/include/opus'
 /usr/bin/install -c -m 644 COPYING AUTHORS README.md '/home/joel16/psp/psp-packages/opusfile/pkg/opusfile/psp/share/doc/opusfile'
libtool: install: /usr/bin/install -c .libs/libopusfile.lai /home/joel16/psp/psp-packages/opusfile/pkg/opusfile/psp/lib/libopusfile.la
libtool: install: /usr/bin/install -c .libs/libopusurl.lai /home/joel16/psp/psp-packages/opusfile/pkg/opusfile/psp/lib/libopusurl.la
libtool: install: /usr/bin/install -c .libs/libopusfile.a /home/joel16/psp/psp-packages/opusfile/pkg/opusfile/psp/lib/libopusfile.a
libtool: install: chmod 644 /home/joel16/psp/psp-packages/opusfile/pkg/opusfile/psp/lib/libopusfile.a
libtool: install: psp-ranlib /home/joel16/psp/psp-packages/opusfile/pkg/opusfile/psp/lib/libopusfile.a
libtool: install: /usr/bin/install -c .libs/libopusurl.a /home/joel16/psp/psp-packages/opusfile/pkg/opusfile/psp/lib/libopusurl.a
libtool: install: chmod 644 /home/joel16/psp/psp-packages/opusfile/pkg/opusfile/psp/lib/libopusurl.a
libtool: install: psp-ranlib /home/joel16/psp/psp-packages/opusfile/pkg/opusfile/psp/lib/libopusurl.a
==> Tidying install...
  -> Purging unwanted files...
  -> Stripping unneeded symbols from binaries and libraries...
  -> Compressing man and info pages...
==> Checking for packaging issues...
==> WARNING: Package contains reference to $pkgdir
psp/lib/pkgconfig/opusurl.pc
psp/lib/libopusfile.la
psp/lib/libopusurl.la
==> Creating package "opusfile"...
  -> Generating .PKGINFO file...
  -> Generating .BUILDINFO file...
  -> Generating .MTREE file...
  -> Compressing package...
==> Leaving fakeroot environment.
==> Finished making: opusfile 0.12-1 (Mon 12 Jan 2026 11:20:11 AM GMT)
==> Installing package opusfile with psp-pacman -U...
loading packages...
warning: opusfile-0.12-1 is up to date -- reinstalling
resolving dependencies...
looking for conflicting packages...

Packages (1) opusfile-0.12-1

Total Installed Size:  0.21 MiB
Net Upgrade Size:      0.00 MiB

:: Proceed with installation? [Y/n]

@sharkwouter
Copy link
Member

sharkwouter commented Jan 12, 2026

Try installing the opus package from the CI, then you'll see the error. I'm confused as to why. You can download it from the artifacts, extract the zip and then install the package with psp-pacman -U. You could also rebuild the opus package locally using psp-makepkg -i.

@joel16
Copy link
Contributor Author

joel16 commented Jan 12, 2026 •
edited
Loading

Try installing the opus package from the CI, then you'll see the error. I'm confused as to why. You can download it from the artifacts, extract the zip and then install the package with psp-pacman -U. You could also rebuild the opus package locally using psp-makepkg -i.

I assume you mean opusfile? I'm not able to reproduce this with either psp-pacman -U or psp-makepkg -i for either libopus or opusfile. I'm using Ubuntu 24.04 WSL2.

@sharkwouter
Copy link
Member

sharkwouter commented Jan 12, 2026

I found the issue, my change from earlier doesn't work. I'm sorry for that. pkgconf can expand variables and it is not doing so.

@sharkwouter
Copy link
Member

sharkwouter commented Jan 12, 2026

I'll get this fixed and merged, sorry for breaking it.

@joel16
Copy link
Contributor Author

joel16 commented Jan 12, 2026

No worries, thank you :)

@sharkwouter sharkwouter merged commit d9934a2 into pspdev:master Jan 13, 2026
1 check passed
@sharkwouter
Copy link
Member

sharkwouter commented Jan 13, 2026

I've fixed the opusurl.pc file now and merged this. Thanks for the contribution @joel16 :)

@joel16 joel16 deleted the opus branch February 7, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sharkwouter sharkwouter sharkwouter requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joel16 @sharkwouter