add script for the custom libme-core mapper library#243
add script for the custom libme-core mapper library#243sharkwouter merged 4 commits intopspdev:masterfrom
Conversation
libmecore/PSPBUILD
Outdated
| @@ -0,0 +1,29 @@ | |||
| pkgname=psp-media-engine-custom-core | |||
There was a problem hiding this comment.
The name of the package and the name of the directory the package is in have to match for our automated builds to work.
There was a problem hiding this comment.
Done! The package now uses libmecore as the folder name to match your build requirements (see last commit).
libmecore/PSPBUILD
Outdated
|
|
||
| package() { | ||
| cd "$srcdir/$reponame-${pkgver}/build" | ||
| make DESTDIR="" install |
There was a problem hiding this comment.
It seems the package now only contains the license. You should probably apply this change:
| make DESTDIR="" install | |
| make DESTDIR="$pkgdir/psp" install |
There was a problem hiding this comment.
Fixed the packaging step, files should now be correctly installed under pkgdir/psp. Thx
492739c to
49c1f0c
Compare
….txt to $pkgdir/psp, remove related empty parent directories, clean script
libmecore/PSPBUILD
Outdated
| make DESTDIR="$pkgdir" install | ||
|
|
||
| mv "$pkgdir/${PSPDEV}/"* "$pkgdir" | ||
|
|
||
| dir="$pkgdir/$PSPDEV" | ||
| while [ "$dir" != "$pkgdir" ]; do | ||
| rmdir "$dir" 2>/dev/null || break | ||
| dir=$(dirname "$dir") | ||
| done |
There was a problem hiding this comment.
The resulting package does look good now, but this construction looks a bit weird to me. Could you copy the files using the install command instead of using the make install command? There are several examples of this in this repo, for example this one: https://github.com/pspdev/psp-packages/blob/master/libpspftp/PSPBUILD
There was a problem hiding this comment.
Updated as required
…stead of make install
|
Thanks! This looks good now |
What does this provide?