add pspftp and pspav#238
Merged
sharkwouter merged 3 commits intopspdev:masterfrom Sep 5, 2025
JoseAaronLopezGarcia:master
Merged
add pspftp and pspav#238sharkwouter merged 3 commits intopspdev:masterfrom JoseAaronLopezGarcia:master
sharkwouter merged 3 commits intopspdev:masterfrom
JoseAaronLopezGarcia:master
Conversation
sharkwouter
reviewed
Sep 4, 2025
Member
sharkwouter
left a comment
There was a problem hiding this comment.
Hey @JoseAaronLopezGarcia thanks for the PR! From what I can see, this should probably still be marked as a draft since the repos used are still empty. I added some comments on things that could be improved anyway :)
Contributor
Author
|
The repos that are pointed to are pending PR themselves. First they need to be merged, then we can fix and merge this one. |
Contributor
Author
|
@sharkwouter I need these two PRs merged before we I can continue with this one: pspdev/libpspav#1 Can you review and potentially merge them? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.