Merged
Conversation
bucanero
commented
Jul 9, 2025
There was a problem hiding this comment.
Pull Request Overview
Adds a PKGBUILD script to compile and install the Unarr decompression library for PSP using the PSPDev toolchain.
- Introduces
unarr/PSPBUILDfor PSP target packaging - Configures CMake with PSP toolchain and installs static libraries
- Installs license file into PSP share directory
Comments suppressed due to low confidence (1)
unarr/PSPBUILD:27
- [nitpick] The
XTRA_OPTSarray is not defined in this script; define it or remove the reference to avoid confusion.
cmake -Wno-dev -DCMAKE_TOOLCHAIN_FILE="${PSPDEV}/psp/share/pspdev.cmake" -DCMAKE_INSTALL_PREFIX="${pkgdir}/psp" \
sharkwouter
reviewed
Jul 9, 2025
unarr/PSPBUILD
Outdated
| mkdir -p build | ||
| cd build | ||
| cmake -Wno-dev -DCMAKE_TOOLCHAIN_FILE="${PSPDEV}/psp/share/pspdev.cmake" -DCMAKE_INSTALL_PREFIX="${pkgdir}/psp" \ | ||
| -DCMAKE_C_FLAGS="-Wno-error=incompatible-pointer-types" \ |
Member
There was a problem hiding this comment.
Is this required for it to build? Just making sure. Otherwise this PR looks great.
Contributor
Author
There was a problem hiding this comment.
hi @sharkwouter , I removed the line: -DCMAKE_C_FLAGS="-Wno-error=incompatible-pointer-types" \ , but not sure if you're also referring to other flags?
bucanero
commented
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unarr library, as mentioned in discord