Hey @sdaheng, great call. You were right that we only had partial hjkl coverage. The buffer picker had j/k, but the session picker (prefix s) and the choose tree picker (prefix w) only listened to the arrow keys. I went and looked at how tmux handles this in mode-tree.c so we line up cleanly.

Just shipped this in commit 2887e08:

Full hjkl + g/G parity across every picker

In tmux the mode tree (which backs choose tree, choose buffer, choose client, and customize mode) treats h and k as up, j and l as down, and g / G as Home / End for flat lists. psmux now does exactly the same in:

choose session (prefix s)
choose tree (prefix w)
choose buffer (prefix =)
list keys viewer (prefix ?)
customize mode

Menus were left alone on purpose, since tmux reserves single character keys in menus as shortcut keys (so binding h to navigation would steal a potential menu shortcut). That matches tmux's behavior.

How I proved it works

I added tests/test_issue259_picker_hjkl.ps1 with two layers:

Source level checks for every KeyCode::Char('h' / 'j' / 'k' / 'l' / 'g' / 'G') arm in each picker so the wiring cannot silently regress.
Live behavioral tests that compile a tiny C# injector, attach a real psmux client to one of four sessions, then use WriteConsoleInput to inject Ctrl+B s plus the nav key plus Enter into the actual console buffer (no screen scraping, no fake events). After the keystroke is dispatched, the test queries each session's session-info over TCP and checks which one carries the (attached) marker. So we are literally proving that pressing j after the picker opens moves the cursor down by one and selects the next session, and G jumps to the last session, etc.

Result: 29 / 29 passing, including the six end to end injection cases for j, k, h, l, g, and G.

This will be in the next release. If you spot any other tmux key path that feels off, please drop it in a new issue and I will line it up.

Supporting hjkl #259

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions