Merged
Conversation
29d01f0 to
9e1c28c
Compare
psibi
reviewed
Oct 13, 2021
psibi
requested changes
Oct 13, 2021
Owner
psibi
left a comment
There was a problem hiding this comment.
LGTM, some minor comments. Can you also update the Changelog ? Thank you!
psibi
reviewed
Oct 13, 2021
Specifically, this gets rid of the {{path/to/file}}
pieces in code.
Most tldr clients parse these and apply different color.
Let's match that.
9e1c28c to
753ac6c
Compare
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically, this gets rid of the {{path/to/file}}
pieces in code.
Most tldr clients parse these and apply different color.
Let's match that.
Haskell tldr
NPM tldr
Haskell tldr with this patch
I couldn't find any impact on performance. The parsing is very quick.