Skip to content

When updating the database, show the download location#30

Merged
psibi merged 2 commits intopsibi:masterfrom
gutjuri:show-download-location
Oct 8, 2020
Merged

When updating the database, show the download location#30
psibi merged 2 commits intopsibi:masterfrom
gutjuri:show-download-location

Conversation

@gutjuri
Copy link
Copy Markdown
Contributor

@gutjuri gutjuri commented Oct 8, 2020

As a user, the location of the tldr pages on disk is very intransparent. I tried to change that. Adding a logging framework and using that seemed overkill, so I stuck to using putStrLn

Copy link
Copy Markdown
Owner

@psibi psibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gutjuri Thanks! LGTM. Can you update the changelog too ?

@gutjuri
Copy link
Copy Markdown
Contributor Author

gutjuri commented Oct 8, 2020

Sure, what's the next version?

@psibi
Copy link
Copy Markdown
Owner

psibi commented Oct 8, 2020

@gutjuri 0.8.1

@gutjuri
Copy link
Copy Markdown
Contributor Author

gutjuri commented Oct 8, 2020

Ok, done!

@psibi psibi merged commit 973b61a into psibi:master Oct 8, 2020
@psibi
Copy link
Copy Markdown
Owner

psibi commented Oct 8, 2020

Thanks!

@gutjuri gutjuri deleted the show-download-location branch October 14, 2020 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants