Merged
Conversation
Owner
|
@alx741 Thanks for the fix. Can you update the changelog and bump the version to 0.2.1 ? I will merge this once the Travis passes. |
Contributor
Author
|
Sure thing |
Owner
|
Thanks. Have released a new version with your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I'm using solarized-light color scheme, and for me it looks like this:
After this fix, it looks right:
I also test it with a dark background, and it works fine:
Making
fgColor = BlackandbgColor = Whitewouldn't work, the reason is that what the terminal's color pallettewhiteis, may or may not be what the background color is. So the result ends up looking wrong again:I can't think of a case on which one would like to have the background of the printed out text to be different to the terminal's background color, hence the fix.