Test verifying that ChunkedEncodingError is raised on an invalid Transfer-Encoding: chunked response.#5906
Merged
nateprewitt merged 1 commit intopsf:mainfrom Aug 25, 2021
Conversation
…invalid Transfer-Encoding: chunked response is returned.
nateprewitt
approved these changes
Aug 25, 2021
Member
nateprewitt
left a comment
There was a problem hiding this comment.
Hey @theGOTOguy, thanks for the contribution. I think the concern of changing from our current chunked implementation to urllib3 is more with request serialization rather than response deserialization.
That said, you're right we're not testing this behavior anywhere when we probably should. We can merge this as a general testing improvement.
Contributor
Author
|
I appreciate the feedback on what tests are needed, @nateprewitt. I will look into request serialization tests next. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This logic is not currently exercised anywhere in requests' tests.
For context, most errors that occur during the process of handling a request can be retried through urllib3's Retry. Currently, chunked encoding bypasses this, leading to a situation where users of requests are left to roll their own custom error handling for chunked encoding. #5664 seeks to remedy that, but there are two issues:
First, the current logic around chunked encoding has limited tests, and there is concern that accepting #5664 would introduce a regression.
Second, switching from requests' internal exceptions to urllib3's exceptions is a breaking change that will require appropriate notification to existing users.
This is a first step towards addressing both issues by exercising the chunked encoding logic internally, introducing a test that will break when requests switches to using urllib3's exceptions for chunked encoding, and providing a simple example to start with for any who seek to write further tests for the chunked encoding logic.