Delegate chunked encoding handling to urllib#4958
Closed
leamingrad wants to merge 1 commit intopsf:masterfrom
Closed
Delegate chunked encoding handling to urllib#4958leamingrad wants to merge 1 commit intopsf:masterfrom
leamingrad wants to merge 1 commit intopsf:masterfrom
Conversation
Author
|
Quick note on testing that I forgot to put in the description: I haven't added any specific tests to cover this feature, but I think that the code is covered by existing tests from what I can see - if there are extras that would be helpful I am happy to add them. |
Codecov Report
@@ Coverage Diff @@
## master #4958 +/- ##
==========================================
- Coverage 66.89% 66.66% -0.24%
==========================================
Files 15 15
Lines 1577 1554 -23
==========================================
- Hits 1055 1036 -19
+ Misses 522 518 -4
Continue to review full report at Codecov.
|
5ac5caa to
144a784
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR removes the custom handling of sending chunked HTTP requests from requests to delegate to the equivalent logic in urllib3 (https://github.com/urllib3/urllib3/blob/4325867d1ae0d139a11c8689c2d2a5ba2c666c83/src/urllib3/connectionpool.py#L351).
As far as I can tell this has a couple of advantages: