Separate subprocess writing/parsing into their own functions#201
Merged
Separate subprocess writing/parsing into their own functions#201
Conversation
And document. As suggested by @corona10 psf#197 (comment)
vstinner
reviewed
Sep 4, 2024
pyperf/_process_time.py
Outdated
| # Write timing in seconds into stdout | ||
| print(dt, file=out) | ||
| print(max_rss or -1, file=out) | ||
| print(json.dumps(metadata), file=out) |
Member
There was a problem hiding this comment.
Can you call .dump() on sys.stdout?
Collaborator
Author
There was a problem hiding this comment.
Sure, that makes sense.
corona10
approved these changes
Sep 5, 2024
Member
corona10
left a comment
There was a problem hiding this comment.
LGTM, Thank you for adopting my suggestions!
Co-authored-by: Victor Stinner <vstinner@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...and document
As suggested by @corona10 #197 (comment)