Conversation
Member
|
If you want to submit the patch related code style issue, would you like to submit the patch including the CI works? |
vstinner
reviewed
Apr 29, 2024
Member
vstinner
left a comment
There was a problem hiding this comment.
Would it be possible to exclude changes converting code to "expr1 if test else expr2"?
Member
This change combines many different changes. Some of them are uncontroversial, I have an opinion on the others :-) |
Contributor
Author
|
I understand. These PRs are super easy to create locally with syntax like: |
Member
|
I'm fine with these changes, coming from the old time when pyperf worked on Python 2: |
Member
|
Merged, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
%
ruff check --select=UP --ignore=UP015,UP031 --statistics | sort -k2%
ruff rule UP024os-error-alias (UP024)
Derived from the pyupgrade linter.
Fix is always available.
What it does
Checks for uses of exceptions that alias
OSError.Why is this bad?
OSErroris the builtin error type used for exceptions that relate to theoperating system.
In Python 3.3, a variety of other exceptions, like
WindowsErrorwerealiased to
OSError. These aliases remain in place for compatibility witholder versions of Python, but may be removed in future versions.
Prefer using
OSErrordirectly, as it is more idiomatic and future-proof.Example
Use instead:
References
OSError