Skip to content

Add support for Python 3.11#142

Merged
corona10 merged 5 commits intopsf:mainfrom
hugovk:add-3.11
Nov 4, 2022
Merged

Add support for Python 3.11#142
corona10 merged 5 commits intopsf:mainfrom
hugovk:add-3.11

Conversation

@hugovk
Copy link
Copy Markdown
Contributor

@hugovk hugovk commented Nov 4, 2022

Also drop support for EOL Python <= 3.6 and fix errors found running tox -e pep8.

Copy link
Copy Markdown
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@corona10 corona10 merged commit 0318d44 into psf:main Nov 4, 2022
@hugovk hugovk deleted the add-3.11 branch November 4, 2022 14:26
@vstinner
Copy link
Copy Markdown
Member

vstinner commented Nov 4, 2022

Also drop support for EOL Python <= 3.6

Does supporting support for Python 3.6 brings anything useful yet? I can easily be tested on a CI. I would prefer to keep it supported until it beaks badly and no one is volunteer to still support it.

@hugovk
Copy link
Copy Markdown
Contributor Author

hugovk commented Nov 4, 2022

It removes a CI job, but that's not a big deal here.

I didn't upgrade the syntax for 3.7+, so it's fine to re-add it.

@vstinner
Copy link
Copy Markdown
Member

vstinner commented Nov 4, 2022

It's not a big deal. I'm also fine with removing Python 3.6 support. Especially, if technically Python 3.6 still works :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants