Merged
Conversation
Collaborator
hauntsaninja
left a comment
There was a problem hiding this comment.
I pushed some more test cases. These may be preexisting, but:
- I think I'd prefer if
simple/longersplit the arguments instead of the generic part. - The formatting in
trailing_comma2looks buggy to me
hauntsaninja
approved these changes
Apr 24, 2024
Collaborator
hauntsaninja
left a comment
There was a problem hiding this comment.
Looks like we have an issue for those too :-)
Collaborator
Author
|
Yes, #4071 for reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.