[Github Action] Directly install from repo. if export-subst is skipped#4313
Merged
JelleZijlstra merged 3 commits intopsf:mainfrom Apr 24, 2024
EarlMilktea:detect-export-subst-fail
Merged
[Github Action] Directly install from repo. if export-subst is skipped#4313JelleZijlstra merged 3 commits intopsf:mainfrom EarlMilktea:detect-export-subst-fail
export-subst is skipped#4313JelleZijlstra merged 3 commits intopsf:mainfrom
EarlMilktea:detect-export-subst-fail
Conversation
export-subst is omittedexport-subst is skipped
for more information, see https://pre-commit.ci
export-subst is skippedexport-subst is skipped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed that, if the github action is called in an unexpected way (such as from https://github.com/nektos/act), substitution of
.git_archival.txtcan be skipped.For that cases, the action tries to execute
pip install black[colorama]==$Format:%(describe:tags=true,match=*[0-9]*)$, which is not making any sense.This PR is trying to fix this behavior.
Checklist - did you ...
CHANGES.mdif necessary?