Skip to content

Improve AST safety check#4290

Merged
JelleZijlstra merged 1 commit intopsf:mainfrom
hauntsaninja:ast-safety
Mar 23, 2024
Merged

Improve AST safety check#4290
JelleZijlstra merged 1 commit intopsf:mainfrom
hauntsaninja:ast-safety

Conversation

@hauntsaninja
Copy link
Collaborator

@hauntsaninja hauntsaninja commented Mar 22, 2024

Fixes #4288, regressed by #4270

@github-actions
Copy link

diff-shades reports zero changes comparing this PR (22f2570) to main (c9d2635).


What is this? | Workflow run | diff-shades documentation

Copy link
Collaborator

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel ideally we should only reformat real docstrings, but this still preserves the invariant that we only change strings that aren't executed, so this is fine.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When reformatting a triple-quote string, black fails with an INTERNAL ERROR: Black produced code that is not equivalent to the source

2 participants