Use regex where we ignore case on windows#4252
Merged
JelleZijlstra merged 1 commit intopsf:mainfrom Mar 13, 2024
Merged
Conversation
On windows the path `FoObAR` is the same as `foobar`, so the output of `black` on a windows machine could output the path to `.gitignore` with an upper or lower-case drive letter.
Contributor
Author
|
I don't think this change will require a change in |
JelleZijlstra
approved these changes
Mar 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I was just about to start testing things, and was running into failed tests on
main. Bothtest_invalid_gitignoreandtest_invalid_nested_gitignoreboth threw errors because of the case-sensitivity of"s" in "STRING"withgitignorebeingc:\\...and the output havingC:\\....On windows the path
FoObARis the same asfoobar, so the output ofblackon a windows machine could output the path to.gitignorewith upper or lower-case portions of the path. In this change we use the regexre.IGNORECASEflag to get it to match properly. We do not do this when thegitignorepath is not apathlib.WindowsPathobject.Checklist - did you ...
CHANGES.mdif necessary? - not necessaryUpdated test output