Fix 4227: Black does not print errors with --quiet --check#4236
Merged
JelleZijlstra merged 10 commits intopsf:mainfrom Mar 13, 2024
Merged
Fix 4227: Black does not print errors with --quiet --check#4236JelleZijlstra merged 10 commits intopsf:mainfrom
JelleZijlstra merged 10 commits intopsf:mainfrom
Conversation
Collaborator
|
Thanks, but I think we don't need to change anything here (except perhaps the docs); see the issue. |
Contributor
Author
|
@JelleZijlstra Sounds good, I can make a small doc adjustment in this PR or create a new PR if desired. |
Collaborator
|
Either works! |
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
for more information, see https://pre-commit.ci
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This closes #4227
black was previously not printing any information when called with the
--quietand--checkflags.the related issue makes a valid point that black should stay quiet on successful runs and notify the user when changes are found.
I've omitted part of the output in an attempt to keep the output still quiet, but I can add it in if desired.
For example, when called without the
--quietflag:When called with the
--quietflag:Checklist - did you ...
CHANGES.mdif necessary?