Conversation
|
@hauntsaninja @cooperlees I think this is ready to go, I'll merge it soon unless you have any objections. After this is merged, I'd also like to add the |
cooperlees
left a comment
There was a problem hiding this comment.
All looks good to me - I tried to look for typos etc. and couldn't find any.
Going to trust a lot of conversation I didn't part take in.
Assuming the diff shades changes are expected.
|
The changelog claims Black standardised on a single newline after module docstrings. However, this is false. I think it could be nice for what the changelog says to be true. I can keep the change ready. Thoughts? Edit: okay, I missed #4027, this is intentional. I can just submit a PR updating the changelog then |
| add_trailing_comma_consistently = auto() | ||
| blank_line_after_nested_stub_class = auto() | ||
| blank_line_between_nested_and_def_stub_file = auto() | ||
| hex_codes_in_unicode_sequences = auto() |
There was a problem hiding this comment.
I believe there's a mistake in the changelog or the flag here is a leftover. The changelog mentions that the hex normalisation shipped, but the preview flag still exists in the code.
There was a problem hiding this comment.
Oops, you're right. I must have confused myself somewhere. I guess this preview feature will have to wait another year.
Closes #4042.
Replacing #4064. I need a branch in this repo instead of my fork so I can create an alpha release from it.
This should mostly become the stable style.
parenthesize_conditional_expressionsandwrap_long_dict_values_in_parensshould be reverted unless the issues currently open for them (listed in #4042) are fixed.