Enable PYTHONWARNDEFAULTENCODING = 1 in CI#3763
Merged
hauntsaninja merged 2 commits intopsf:mainfrom Jul 4, 2023
Merged
Conversation
e5d4a91 to
cc90345
Compare
cc90345 to
d07c923
Compare
hauntsaninja
approved these changes
Jul 4, 2023
Collaborator
hauntsaninja
left a comment
There was a problem hiding this comment.
Thanks for fixing these!
Contributor
Author
|
No problem! I'm looking forward to HypothesisWorks/hypothesis#3691 running clean on upstream releases 😁 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3658, and ensures that #3695 won't regress later.
For clarity I switched most uses of
with open(...)to usepathlib, including a few where the encoding was already OK - I find it much easier to read boilerplate-y tests when they're consistent, and I thought it was worth maintaining that.