Merged
Conversation
The crash reproes on 22.12.1 but appears to be fixed on main; add a test to make sure.
JelleZijlstra
commented
Dec 20, 2022
cooperlees
approved these changes
Jan 16, 2023
Collaborator
cooperlees
left a comment
There was a problem hiding this comment.
Logic seems sane when we add what space to set the bool + use. Tests are good and make sense.
Will leave it to you to rebase or I can to merge?
Collaborator
Author
|
Thanks, just fixed the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3425. Fixes #3427.