Skip to content

fix(type): type annotation#3416

Merged
JelleZijlstra merged 1 commit intopsf:mainfrom
isac322:fix_type_annotation
Dec 10, 2022
Merged

fix(type): type annotation#3416
JelleZijlstra merged 1 commit intopsf:mainfrom
isac322:fix_type_annotation

Conversation

@isac322
Copy link
Contributor

@isac322 isac322 commented Dec 10, 2022

Description

mypyc reports error src/black/__init__.py:670:29: error: Incompatible types in assignment (expression has type "Dict[Any, PathSpec]", variable has type "Optional[PathSpec]") [assignment] (https://github.com/isac322/docker_image_blackd/actions/runs/3663490540/jobs/6193303572#step:7:1640)

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

Copy link
Collaborator

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this started failing because pathspec just did a release adding a py.typed file: https://github.com/cpburnz/python-pathspec/blob/master/CHANGES.rst

@JelleZijlstra JelleZijlstra added the ci: skip news Pull requests that don't need a changelog entry. label Dec 10, 2022
@JelleZijlstra
Copy link
Collaborator

The diff-shades build is failing because it tries to build main for the baseline. Going to merge this to unblock CI.

@JelleZijlstra JelleZijlstra merged commit 1f7f6de into psf:main Dec 10, 2022
@isac322 isac322 deleted the fix_type_annotation branch December 10, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: skip news Pull requests that don't need a changelog entry.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants