Fix unstable formatting with some # type: ignores#1113
Merged
JelleZijlstra merged 1 commit intopsf:masterfrom Nov 25, 2019
Merged
Fix unstable formatting with some # type: ignores#1113JelleZijlstra merged 1 commit intopsf:masterfrom
# type: ignores#1113JelleZijlstra merged 1 commit intopsf:masterfrom
Conversation
`type: ignore` shouldn't block collapsing a line, since it will still apply fine to the merged line. This prevents an issue where a reformat causes it to shift lines and then be merged on a subsequent pass. There is a downside to this, which is that it can cause a `type: ignore` to apply to more code than was originally intended. There might be a way to apply this in a more limited situation, but I'm not sure what it is. Fixes psf#1061.
msullivan
commented
Oct 29, 2019
Collaborator
|
Sorry for the delay! |
This was referenced Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
type: ignoreshouldn't block collapsing a line, since it will stillapply fine to the merged line. This prevents an issue where a reformat
causes it to shift lines and then be merged on a subsequent pass.
There is a downside to this, which is that it can cause a
type: ignoreto apply to more code than was originally intended. Theremight be a way to apply this in a more limited situation, but I'm not
sure what it is.
Fixes #1061.