Feature: restart language server on project switching when using workspaces#184
Merged
tm1000 merged 5 commits intopsalm:masterfrom Jul 25, 2022
Merged
Feature: restart language server on project switching when using workspaces#184tm1000 merged 5 commits intopsalm:masterfrom
tm1000 merged 5 commits intopsalm:masterfrom
Conversation
Each time the user switches to a different workspace, the language server will point to that workspace then restart.
When restarting the language server it will also try to load the local (to the project) psalm config file (usually psalm.xml)
tm1000
requested changes
Jul 25, 2022
Collaborator
|
Hey there this looks pretty great! I just have one comment. Review it and let me know your thoughts |
Collaborator
|
2.7.0 🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each time the user switches to a different project within a workspace the language server will point to that project then restart.
Previously the language server would always point to the first project in the workspace ( see #104 (comment) ).
Improvements are welcomed.
Related to #104