Skip to content

fix: Argument::that allows params#73

Merged
weirdan merged 2 commits intopsalm:masterfrom
mr-feek:fix-that
May 24, 2020
Merged

fix: Argument::that allows params#73
weirdan merged 2 commits intopsalm:masterfrom
mr-feek:fix-that

Conversation

@mr-feek
Copy link
Copy Markdown
Contributor

@mr-feek mr-feek commented May 24, 2020

fixes #72

@weirdan
Copy link
Copy Markdown
Member

weirdan commented May 24, 2020

Mind adding a test for this?

@weirdan
Copy link
Copy Markdown
Member

weirdan commented May 24, 2020

Also you may want to rebase - I've just fixed tests in master

@mr-feek
Copy link
Copy Markdown
Contributor Author

mr-feek commented May 24, 2020

sure, comin right up

@mr-feek
Copy link
Copy Markdown
Contributor Author

mr-feek commented May 24, 2020

how's that lookin @weirdan ? I figured Prophecy was worthy of its own test case, since it's relatively independent of phpunit

@weirdan
Copy link
Copy Markdown
Member

weirdan commented May 24, 2020

Looking good!

@weirdan weirdan merged commit 138998f into psalm:master May 24, 2020
@weirdan
Copy link
Copy Markdown
Member

weirdan commented May 24, 2020

Released in 0.10.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Prophecy][False Positive] Argument::that problems

2 participants