Fix exception class in InvocationMocker und MockBuilder strub#109
Merged
weirdan merged 1 commit intopsalm:masterfrom May 29, 2021
Merged
Fix exception class in InvocationMocker und MockBuilder strub#109weirdan merged 1 commit intopsalm:masterfrom
weirdan merged 1 commit intopsalm:masterfrom
Conversation
Member
|
I fixed test failures on master, mind rebasing this? I can't push to your repo, either because you did not enable 'Updates from maintainers' checkbox or because the PR was created from weph:master and not from a dedicated branch. |
Contributor
Author
|
I checked "Allow edits by maintainers" and according to the help text you should be allowed to push to my master 🤷🏻♂️ |
Member
|
Thanks! |
Member
|
Released in 0.15.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After enabling
checkForThrowsDocblockpsalm crashed withI had a look at PHPUnit and there really isn't a
RuntimeExceptionin that namespaces and after browsing through some versions I think there never has been. So I guess what's really meant is the global one.