bpo-34456: pickle: Add missing NULL check to save_global(). (pythonGH-8851)

Alexey Izbyshev · serhiy-storchaka · commit f8c06b028036 · 2018-08-22T07:51:25.000+03:00
Reported by Svace static analyzer.
diff --git a/Modules/_pickle.c b/Modules/_pickle.c
@@ -3454,6 +3454,8 @@ save_global(PicklerObject *self, PyObject *obj, PyObject *name)
             PickleState *st = _Pickle_GetGlobalState();
             PyObject *reduce_value = Py_BuildValue("(O(OO))",
                                         st->getattr, parent, lastname);
+            if (reduce_value == NULL)
+                goto error;
             status = save_reduce(self, reduce_value, NULL);
             Py_DECREF(reduce_value);
             if (status < 0)
