Skip to content

Conversation

@gpauloski
Copy link
Collaborator

Description

A prior PR changed the default to fqdn, which resulted in a few users having to revert back to IP host name resolution. This reverts the default back to IP for broader compatibility.

I also added a "static" host type so users can force their endpoint host to be at a certain address, rather than trying to infer the correct host from the IP address or fqdn.

See #672 for the PR that added and changed the default to fqdn.

Fixes N/A

Type of Change

  • Breaking Change (fix or enhancement which changes existing semantics of the public interface)
  • Enhancement (new features or improvements to existing functionality)
  • Bug (fixes for a bug or issue)
  • Internal (refactoring, style changes, testing, optimizations)
  • Documentation update (changes to documentation or examples)
  • Package (dependencies, versions, package metadata)
  • Development (CI workflows, pre-commit, linters, templates)
  • Security (security related changes)

Testing

Tested locally and added some new unit tests.

Pull Request Checklist

Please confirm the PR meets the following requirements.

  • Tags added to PR (e.g., breaking, bug, enhancement, internal, documentation, package, development, security).
  • Code changes pass pre-commit (e.g., mypy, ruff, etc.).
  • Tests have been added to show the fix is effective or that the new feature works.
  • New and existing unit tests pass locally with the changes.
  • Docs have been updated and reviewed if relevant.

A prior PR changed the default to fqdn, which resulted in a few users
having to revert back to IP host name resolution. This reverts the
default back to IP for broader compatibility.

I also added a "static" host type so users can force their endpoint
host to be at a certain address, rather than trying to infer the
correct host from the IP address or fqdn.
@gpauloski gpauloski added the enhancement New features or improvements to existing functionality label Apr 23, 2025
@gpauloski gpauloski merged commit 7f1806c into main Apr 23, 2025
12 checks passed
@gpauloski gpauloski deleted the endpoint-host-resolution branch April 23, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or improvements to existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants