Skip data_access scopes on HA Globus Collections and add CLI option for session required domains
#680
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue collaborators had using ProxyStore's
GlobusConnectorat OLCF which uses high assurance collections which do not havedata_accessscopes. This would produce an "Unknown scopes" error when following the link to perform the Globus auth token exchange.The
get_transfer_client()method now checks the type of the collection before addingdata_accessscopes and the CLI help message has been updated to instruct users not to include HA collections.This wasn't quite enough to fix the OLCF use case though. It turns out the session tokens also need to require an associated identity from a specific domain. The CLI has been updated to provide require domains that get passed along to the scope creation.
Fixes
data_accessscopes for HA Globus Endpoints #679Type of Change
Testing
Added unit tests and tested using a Globus HA test collection.
Pull Request Checklist
Please confirm the PR meets the following requirements.
pre-commit(e.g., mypy, ruff, etc.).